[CI] Stop Windows pipeline upon a failing pytest #10003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcho3
changed the title
This reverts commit d1338b7.
|
@trivialfis Can you help debug the failing pytest |
|
Will look into it. |
|
There's a bug in MSVC + NVCC, it somehow enters a condition even though it's false (explicitly printed and verified to be false). Trying to come up with a workaround. |
trivialfis
approved these changes
Jan 25, 2024
|
Thank you for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9618
Currently, the Windows CI pipeline continues to execute even when a pytest fails. Example: https://buildkite.com/xgboost/xgboost-ci-windows/builds/4475#018d34ec-1805-4b3a-8206-e4addbae123f/2297-23796
This is because a PowerShell script doesn't stop automatically when a child process returns a non-zero exit code. See https://stackoverflow.com/a/9949909.
Fix: Explicitly check the exit code from the pytest suites and terminate the script as needed. Example: https://buildkite.com/xgboost/xgboost-ci-windows/builds/4477#018d3862-44d6-4219-8f40-7db901f8653a/4179-25710